feat: Convert DashboardPlugins to WidgetPlugins #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
- Coverage 46.74% 46.69% -0.05%
==========================================
Files 583 583
Lines 36256 36264 +8
Branches 9072 9074 +2
==========================================
- Hits 16947 16933 -14
- Misses 19257 19279 +22
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mofojed
requested changes
Oct 26, 2023
mofojed
requested changes
Oct 27, 2023
mofojed
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1573
This fix should be adequate for furthering the Deephaven UI alpha. Rather than trying to refactor 2 1k+ line files (IrisGridPanel and ChartPanel), I opted to add some DOM detection to the
Panelcomponent to prevent rendering tab context menu/tooltips if it is nested within another panel.For Deephaven UI, we will need to ensure the UI panel uses
Panelat least and passes throughglContainerandglEventHubto the child elements so grids and charts function roughly as normal.Testing
To test how something would look/function when wrapped, remove the
panelComponentline from either of the plugin configs. This will wrap in a genericWidgetPanelwhich you can see in dev tools. The panel tab will not have any of the custom tooltip for grid or custom context menus.Test by opening grids/figures, applying some filters/sorts and then reloading the page to ensure the state persisted. Also test adding links and ensuring those persisted on reload. Test that a chart built with chart builder works and survives a reload as well.
Followup
We might be able to convert
MarkdownPluginandFilterPlugin, but I wanted to get the main components in first. Not sure if those would work as WidgetPlugins as currently constructed since they don't listen forPanelEvent.OPEN.FilterPluginprobably makes sense to split into a suite of plugins for each filter type which would need #1587